Allow ssh and sshconfig tags for ssh config syntax highlighting. #7041
Comments
|
We'd certainly accept a PR if you've got the time 😉 |
|
I'm not familiar with how the repo is laid out, but a brief search for linguist/lib/linguist/languages.yml Lines 6522 to 6534 in f0aebbe According to that, I would think Perhaps the previous test was rendered years ago, made inactive, and never re-rendered. I'll try again now:
Host my-nickname
Hostname my-nickname.example.com
User me
|
|
@lildude Can you direct me as to what I should be looking for? The thing that seemed the obvious thing either isn't applied to the deployed GitHub editor at large, or is a red herring. |
|
If you're wanting to use the various other forms, you should add an |
Describe the enhancement
Support
```sshconfig,```ssh, and```ssh-configtags for sshconfig highlight blocks.Support in the Wild
At the time of the previous issue discussion ssh config (#3450), the
Includedirective for ssh config was not well known, nor widely adopted.However, now it is supported in macOS, Ubuntu, and many other Linuxes (anything with OpenSSH 8.x or higher): https://man.openbsd.org/ssh_config.5
Although the
Includedirective does not specify which extension should be used,.sshand.sshconfigseem to be the common extensions, when one is used.vimalso names its syntax highlightingsshconfig.Specifically,
.ssh-configis NOT a common extention andssh-configis not a common name for the syntax - at least not as far as I can tell.As can be seen in #3450 (comment), currently only
```ssh-configis supported by GitHub.Recommendations
I'm recommending that
sshconfig, in particular, be added for syntax highlighting as it seems to be the de facto naming convention.I'd also recommend
sshbecause it's the most intuitive - and I highly, highly doubt that there will be some sort of OpenSSH DSL script that would need thesshtag in the future. That said, I do understand that, categorically,sshmight feel wrong as it would seem to describe an ssh DSL rather than a config format. However, since the layperson would reasonably assume thatsshis the syntax and probably isn't aware thatsshconfigis the de facto name for the syntax.On another note, I would argue against
ssh_configas the tag as that seems to defy the tag convention, and refers specifically to the file naming convention used for substituting the/in~/.ssh/configand the suggested system-wide configuration file name/etc/ssh/ssh_config, not the syntax itself.The text was updated successfully, but these errors were encountered: