Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quick-xml incompatible in the future #2452

Open
wermos opened this issue Mar 7, 2024 · 4 comments
Open

quick-xml incompatible in the future #2452

wermos opened this issue Mar 7, 2024 · 4 comments

Comments

@wermos
Copy link
Contributor

wermos commented Mar 7, 2024

Bug Report

Environment

Ubuntu 23.10, with rustc version 1.76.0

Zola version:
0.18.0

Expected Behavior

Tell us what should have happened.
No warnings should be emitted.

Current Behavior

This is a minor issue, but I thought I'd add it here anyways. Building zola from source emits this warning at the end:

warning: the following packages contain code that will be rejected by a future version of Rust: quick-xml v0.17.2

Since I am not too fluent in Rust, I am not sure how serious the warning is.

Step to reproduce

Please provide the steps to reproduce the issue.
If the issue is hard to reproduce, please provide a sample repository or sample
that triggers the bug.
Build zola from source.

@Keats
Copy link
Collaborator

Keats commented Mar 8, 2024

It needs to be fixed but I believe the library we are using were planning to fix it last time i checked (months ago).

@piotr-calus
Copy link

It needs to be fixed but I believe the library we are using were planning to fix it last time i checked (months ago).

Yes, there is an open PR bumping the minidom version, which will remove the dependency on quick-xml

@Keats
Copy link
Collaborator

Keats commented Aug 21, 2024

Looks like they might be planning to archive that crate so we should probably move away from it as well.

@yabozdar
Copy link

@Keats Following the issue now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants