Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(rules): Fix typing for rule_snooze & rule #80306

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Christinarlong
Copy link
Contributor

Trying a new thing where we try and do all (read: most) of the typing upfront and then move the modules to their new home.

issue ref #73858

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 6, 2024
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 84.00000% with 4 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/api/serializers/rest_framework/rule.py 72.72% 3 Missing ⚠️
src/sentry/api/endpoints/rule_snooze.py 92.85% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #80306       +/-   ##
===========================================
+ Coverage   51.11%   78.09%   +26.98%     
===========================================
  Files        7154     7185       +31     
  Lines      315858   317437     +1579     
  Branches    43555    43743      +188     
===========================================
+ Hits       161444   247910    +86466     
+ Misses     153294    63184    -90110     
- Partials     1120     6343     +5223     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant