Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support c++ module(or symbol) on ownership rule #80230

Open
ganadist opened this issue Nov 5, 2024 · 3 comments
Open

Support c++ module(or symbol) on ownership rule #80230

ganadist opened this issue Nov 5, 2024 · 3 comments
Labels
Product Area: Issues Sync: Jira apply to auto-create a Jira shadow ticket

Comments

@ganadist
Copy link

ganadist commented Nov 5, 2024

Problem Statement

For Java, ownership rule supports module:package.name.xxx pattern.
But, for C/C++, it looks ownership rule does not support 'module:cppmodule::xxxormodule:c_symbol` pattern.

So, auto assignee feature is not working for Sentry native (or android for JNI) projects.

Please consider to support C/C++(or other native) symbols on ownership rule.

Solution Brainstorm

No response

Product Area

Processing

┆Issue is synchronized with this Jira Improvement by Unito

@getsantry
Copy link
Contributor

getsantry bot commented Nov 5, 2024

Assigning to @getsentry/support for routing ⏲️

@getsantry
Copy link
Contributor

getsantry bot commented Nov 5, 2024

Routing to @getsentry/product-owners-issues for triage ⏲️

@leeandher
Copy link
Member

leeandher commented Nov 5, 2024

Hi there, thanks for creating this issue. Is it possible to share a link to a project/issue where you are experiencing this problem? Most features in Sentry are not platform-specific, so if it works for Java, I believe it should also work for C/C++, though I'm not the most familiar with those languages.

I was able to set up rules following your example on a 'native' platform project, is the problem that they aren't being applied correctly?
Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Product Area: Issues Sync: Jira apply to auto-create a Jira shadow ticket
Projects
Status: No status
Development

No branches or pull requests

4 participants