-
-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use spotlight without supplying a DSN #2213
Comments
Yeah sounds good, afaik other sdks do it as well e.g getsentry/sentry-ruby#2226 and same feature request on .net getsentry/sentry-dotnet#3481 |
From the Dart SDK perspective it's pretty much just a change in the init assertion, would there be more needed on the native SDKs to make it possible? |
probably the same, I don't think the native sdks currently allow using spotlight without dsn as well. |
Blocked by #2282 <- I want this issue done first |
@buenaflor if (!options.isEnabled() || (dsn != null && dsn.isEmpty())) {
close();
return false;
} else if (dsn == null) {
throw new IllegalArgumentException(
"DSN is required. Use empty string or set enabled to false in SentryOptions to disable SDK.");
} |
@buenaflor I think this is unblocked as #2282 has been fixed with #2285 |
@kahest this is not fully unblocked yet because the cocoa and android sdk doesn't support this feature yet (we use the native sdk spotlight option there) I'll open an issue for that in the cocoa and android repo |
Problem Statement
I want to be able to use spotlight without having to add a DSN.
Solution Brainstorm
Don't throw when spotlight is enabled, but no DSN is configured.
I have no clue whether this is an intended use case, but it would be nice if it's possible.
Are you willing to submit a PR?
Yes
🛑 Blocked by
The text was updated successfully, but these errors were encountered: