Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log out if session no longer exists #705

Open
matthew-white opened this issue Jan 21, 2023 · 0 comments
Open

Log out if session no longer exists #705

matthew-white opened this issue Jan 21, 2023 · 0 comments

Comments

@matthew-white
Copy link
Member

There are a few ways that a user's session could be deleted or no longer exist before the session expires without the user logging out, none of them extremely likely. One example: restoring a backup will cause any sessions created after the backup was created to no longer exist.

Frontend automatically logs out before a session expires, but it doesn't account for the possibility that a session could stop existing before it expires. If that happens, then Frontend will continue sending requests, but it will show the resulting 401 errors. Instead, I think it'd be better for Frontend to log out immediately in that case. (Should it just log out whenever it receives a 401? Or maybe receiving a 401 should cause it to try to check the existence of the session?)

matthew-white added a commit that referenced this issue Jan 22, 2023
I don't think an admin would ever want to reset and invalidate their own
password rather than changing their password. If they did invalidate
their password, their sessions would be deleted, including their current
session. That would lead to the issue described in #705.
matthew-white added a commit that referenced this issue Jan 24, 2023
I don't think an admin would ever want to reset and invalidate their own
password rather than changing their password. If they did invalidate
their password, their sessions would be deleted, including their current
session. That would lead to the issue described in #705.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant