Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImageMagick compatibilty issue on Ubuntu latest as 24 #6744

Open
afbora opened this issue Oct 15, 2024 · 4 comments · May be fixed by #6754
Open

ImageMagick compatibilty issue on Ubuntu latest as 24 #6744

afbora opened this issue Oct 15, 2024 · 4 comments · May be fixed by #6754
Labels
type: bug 🐛 Is a bug; fixes a bug

Comments

@afbora
Copy link
Member

afbora commented Oct 15, 2024

We used runs-on: ubuntu-22.04 as temporary solution in here: #6743

Check out some failed actions:

NOTE: Maybe the title may sound like an IM issue. But as far as I understand, the problem is related to Kirby. The commands supported by Kirby in IM6 and IM7 do not match. For example, the convert command seems to be deprecated and replaced by the magick command.

@afbora afbora added the type: bug 🐛 Is a bug; fixes a bug label Oct 15, 2024
@bastianallgeier
Copy link
Member

bastianallgeier commented Oct 15, 2024

I wonder if we should use this chance to actually switch to the imagick PHP extension and depracate the use of exec entirely. This would introduce a new dependency on the imagick extension, but also solve some additional problems and potential future security risks.

@distantnative
Copy link
Member

distantnative commented Oct 15, 2024

Started with a first attempt, just a few failing tests still: https://github.com/getkirby/kirby/tree/v5/refactor/imagick

Is there much of a difference between webspace having the CLI available vs. those having the class from the extension ready? Would we cut off users that have been using IM now, if they don't control their webspace?

@bastianallgeier
Copy link
Member

I don't have any stats on this. My personal "feeling" is that shared hosting with IM support has the extension installed by default. At least from what I've seen so far. But it could be an issue on self managed VPSes. I'm pretty sure we would meet people who have used im before but don't have the extension.

We could maybe also think about keeping the old code, deprecate it and add the imagick version as a new default driver.

@distantnative distantnative linked a pull request Oct 16, 2024 that will close this issue
8 tasks
@afbora
Copy link
Member Author

afbora commented Oct 16, 2024

Related issue: convert command deprecated #6534

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 Is a bug; fixes a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants