Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deducted fee is not considered in the max quantity calculation #2477

Open
holzeis opened this issue Apr 25, 2024 · 0 comments
Open

Deducted fee is not considered in the max quantity calculation #2477

holzeis opened this issue Apr 25, 2024 · 0 comments
Labels
bug Something isn't working good-first-issue Good for newcomers UX

Comments

@holzeis
Copy link
Contributor

holzeis commented Apr 25, 2024

easy reproducible on test with a 100% fee rebate. After buying or selling max the max will only decrease but not go to 0 on the next trade.

This is because the max quantity calculation considers the full fee without the rebate.

@holzeis holzeis added bug Something isn't working UX labels Apr 25, 2024
@bonomat bonomat added the good-first-issue Good for newcomers label Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good-first-issue Good for newcomers UX
Projects
None yet
Development

No branches or pull requests

2 participants