Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ethexe: extend replySent to emit different event if value is claimed #4180

Open
jekennedy opened this issue Aug 22, 2024 · 0 comments
Open

ethexe: extend replySent to emit different event if value is claimed #4180

jekennedy opened this issue Aug 22, 2024 · 0 comments

Comments

@jekennedy
Copy link

Problem to Solve

In ethexe/contracts/src/Mirror.sol, the function replySent attempts to transfer tokens to a given destination, and then emits a Reply event. Depending on whether value is greater than 0, a transfer may or may not happen. It would be useful for the caller to know if a transfer actually took place or not.

Possible Solution

If value is greater than 0, emit a different event, like ReplyAndValueClaimed.

Notes

No response
@grishasobol grishasobol changed the title extend replySent to emit different event if value is claimed ethexe: extend replySent to emit different event if value is claimed Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jekennedy