Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ethexe: move NetworkMessage out of service module and consider other structure #4176

Open
grishasobol opened this issue Aug 21, 2024 · 0 comments
Labels
A4-insubstantial Not too important PR C2-refactoring Refactoring proposal

Comments

@grishasobol
Copy link
Member

File Location(s)

ethexe/cli/src/service.rs

Proposal

Move NetworkMessage to another module
Change to something like:

#[derive(Debug, Clone, Encode, Decode)]
pub enum NetworkMessage {
    Commitments {
           Publish { .. }
           RequestValidation { .. }
           Approve { .. }
    },
}
@grishasobol grishasobol added C2-refactoring Refactoring proposal A4-insubstantial Not too important PR labels Aug 21, 2024
@grishasobol grishasobol changed the title ethexe: move NetworkMessage out of service module and consider other structure ethexe: move NetworkMessage out of service module and consider other structure Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A4-insubstantial Not too important PR C2-refactoring Refactoring proposal
Projects
None yet
Development

No branches or pull requests

1 participant