-
-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving option.getOrElse type inference #1917
Comments
thank you for the issue I'm already using your proposed implementation with the intrinsic ts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
🚀 Feature request
Current Behavior
Today, when using
option.getOrElse
, the type of what's inside the option is inferred from the first argument (the or else argument). This leads to typescript easily erroring when returning an array or an option.none (non exhaustive list):To fix this, I can use
getOrElseW
but the resulting type will be not that great (readonly string[] | never[]
) or enforce the type like this:Desired Behavior
It would be great that the inference would be done from the option that is passed to
getOrElse
instead so that this would be valid code:Suggested Solution
Use
NoInfer
from ts-toolbelt. Here's the implementation if we don't want to add a new dependency:and use it like this:
Who does this impact? Who is this for?
This can impact any user and would help greatly new users that don't understand why typescript is not happy.
Describe alternatives you've considered
None
Additional context
Your environment
The text was updated successfully, but these errors were encountered: