Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add drum display #4

Open
garrensmith opened this issue Aug 18, 2018 · 6 comments
Open

Add drum display #4

garrensmith opened this issue Aug 18, 2018 · 6 comments
Labels
enhancement New feature or request

Comments

@garrensmith
Copy link
Owner

Currently this library automatically sets the push into an isomorphic layout for playing notes. It would be nice to also get the pads to layout for playing a drum rack.

@garrensmith garrensmith added the enhancement New feature or request label Aug 18, 2018
@txbrown
Copy link
Collaborator

txbrown commented Aug 18, 2018

@garrensmith perfect as this is one of the things I wanted to add as well. Perhaps even integration with multiple midi devices? If r separate te music logic and reuse for implementation with other devices.

@garrensmith
Copy link
Owner Author

garrensmith commented Aug 18, 2018 via email

@txbrown
Copy link
Collaborator

txbrown commented Aug 21, 2018

@garrensmith I am thinking of doing this in a way similar to how it works on Ableton Live, where you have about 16 drum positions and you can paginate by using the slider on the left. Thoughts?

@garrensmith
Copy link
Owner Author

Yes awesome. I think lets keep it simply for the first attempt and start with just the 16 drum positions. We can add in the slider later.

@txbrown
Copy link
Collaborator

txbrown commented Aug 28, 2018

@garrensmith I made an initial play to see if I could achieve this. I noticed I would have to refactor a bit of the index.js code, perhaps break it down into 2 parts: isomorphicMode.js and drumMode.js and use each based on options passed by the lib consumer.

I have also added webpack to build dev and production (which uses babel-loader and will allow us to have a smaller footprint in package and offers future flexibility), and also for debugging locally with webpack-dev-server, which allows to quickly make changes to lib and get instant feedback with hot-module-reload.

Let me know if these steps make sense and if there is a better approach you may suggest.

Cheers

@garrensmith
Copy link
Owner Author

Ok great. Yes I was thinking you would have to do similar. Maybe create an examples folder with an index.html that can work with webpack-dev-server and that can have an example of using the drumMode.js. I can add an isomorhpicMode.js later. I've given you write permission to this repo. If you want you can push your code onto a branch and we can collaborate on it a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants