Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display more information about current target (target view/describe) #120

Open
petersutter opened this issue Feb 22, 2022 · 3 comments
Open
Labels
component/gardenctl Gardener CLI kind/enhancement Enhancement, improvement, extension lifecycle/rotten Nobody worked on this for 12 months (final aging stage)

Comments

@petersutter
Copy link
Member

petersutter commented Feb 22, 2022

What would you like to be added:
It should be possible to display more information about the current target, e.g. show shoot, control-plane, project, garden, seed, provider in case the information can be derived from the current target.

Why is this needed:

@petersutter petersutter added component/gardenctl Gardener CLI kind/enhancement Enhancement, improvement, extension labels Feb 22, 2022
@petersutter petersutter changed the title Display more information about current target (target view) Display more information about current target (target view/describe) Mar 9, 2022
@gardener-robot gardener-robot added the lifecycle/stale Nobody worked on this for 6 months (will further age) label Sep 6, 2022
@petersutter
Copy link
Member Author

related issue #109

@tedteng
Copy link
Contributor

tedteng commented Nov 21, 2022

per information #120 and #109, I don't know which one is best. either display required information after targeting the shoot cluster gardenctl target --project xx --project xx --shoot xx, or display all information when gardenctl target view is called.

a user case I can think of is to display seed information after the target shoot cluster, plus target command guide, and fetch provider env from os env to display it. eg AZURE_CLIENT_ID=, AZURE_CLIENT_SECRET,AZURE_TENANT_ID etc, if no objections I like to work on this feature. extend gardenctl target view with full information flag

without flag: still the same as current
gtv gardenctl target view

garden: local
project: my-project
shoot: my-shoot

with flag:

gardenctl target view -foo

garden: local
project: my-project
shoot: my-shoot
seed: my-seed

Target garden: gardenctl target --garden local
Target project: gardenctl target --garden local --project my-project
Target shoot: gardenctl target --garden local --seed my-seed 
Target seed: gardenctl target --garden local --project seedproject --shoot my-seed

KUBECONFIG=/var/xxx/kubeconfig.yaml
AZURE_CLIENT_ID=abc
AZURE_CLIENT_SECRET=abc
AZURE_TENANT_ID=abc
AZURE_SUBSCRIPTION_ID=abc
AZURE_CONFIG_DIR=/var/f6fd/.config/az

@petersutter
Copy link
Member Author

First we should agree on what should be displayed before working on this issue and how should the command be used. -foo flag as placeholder is not helpful for the discussion.

Btw., with provider information I was referring to aws, gcp etc. provider type.

I do not think it's a good idea to print the env variables. What should be the benefit?

I also do not see a use case for printing out

Target garden: gardenctl target --garden local
Target project: gardenctl target --garden local --project my-project
Target shoot: gardenctl target --garden local --seed my-seed 
Target seed: gardenctl target --garden local --project seedproject --shoot my-seed

@gardener-robot gardener-robot added lifecycle/rotten Nobody worked on this for 12 months (final aging stage) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/gardenctl Gardener CLI kind/enhancement Enhancement, improvement, extension lifecycle/rotten Nobody worked on this for 12 months (final aging stage)
Projects
None yet
Development

No branches or pull requests

3 participants