Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR #30 kills macOS compilation #36

Open
HomeACcessoryKid opened this issue Sep 30, 2018 · 2 comments
Open

PR #30 kills macOS compilation #36

HomeACcessoryKid opened this issue Sep 30, 2018 · 2 comments

Comments

@HomeACcessoryKid
Copy link

See the discussion at the end of #30
@rzr
Copy link
Collaborator

rzr commented Sep 30, 2018

Sorry for this regression, I guess it can be easy to fix using cmake:
https://cmake.org/cmake/help/v3.0/variable/CMAKE_SYSTEM_NAME.html

rzr added a commit to rzr/xscopes-qt that referenced this issue Sep 30, 2018
@rzr
build: Add local lib path for darwin and windows
0fc8478 
In longer term it would make sense to remove those libs
and use system's ones like linux

Change-Id: I6399b9715b245c2cc11828a0f3bb8f825f72c0c3
Bug: ganzziani#36
Signed-off-by: Philippe Coval <[email protected]>
@rzr rzr mentioned this issue Sep 30, 2018
Merged
@rzr
Copy link
Collaborator

rzr commented Sep 30, 2018

Please try this change, eventually suggest me a way to remote build it.
Regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rzr @HomeACcessoryKid