Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XML model are not regenerated for lightcurve #139

Open
mdebony opened this issue May 14, 2019 · 1 comment
Open

XML model are not regenerated for lightcurve #139

mdebony opened this issue May 14, 2019 · 1 comment

Comments

@mdebony
Copy link
Contributor

mdebony commented May 14, 2019

Hi,

After changing the catalog used for XML model (3FGL to 4FGL), I run enrico_xml and then enrico_sed. It's work fine.
Then I run enrico_lc, after light curve have run I note the XML models used by lightcurve are still the old one.
I suppress the lightcurve folder and rerun enrico_lc and there it was the right XML models which are used.

Cheers,

@mireianievas
Copy link
Contributor

mireianievas commented Jul 31, 2019

I don't really understand the question, could you reformulate it? Why do you need the xml file to be regenerated for the LC?. You mean that you were using the 3fgl before and there are still xml files for the LCs not updated to the 4fgl after running enrico_lc or enrico_xml?.

If this is the case, I think the issue is trickier than it looks. When you run the analysis, the srcmap files are linked somehow to a particular xml model. If you happen to repeat the analysis changing the xml model but not touching the srcmap, the output may not be really correct. As options I would suggest:

  • Force the user to take care about the cleanup of the xml and srcmap files.
  • Do the cleaning of both files in the analysis (at the cost of running the gtsrcmap tool even in cases where it is not needed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants