Differential temperature pump control

[Ivailo1980]

Hi. I`m trying to write some custom code for differentil temperature pump control with one of the ESP 32 relays and BSB lan. I wrote the following:

if (custom_timer > custom_timer_compare+30000) {    // every 30 seconds  
  custom_timer_compare = millis();
query(20302.1)					//read Temp_Freon
float Temp_Freon = atof(decodedTelegram.value);
Serial.println(“Freon temperature: “);
Serialprintln(Temp_Freon);
query(8830)					//read DHW temperature top
float Temp_DHW_top = atof(decodedTelegram.value);
Serial.println(“DHW top temperature: “);
Serialprintln(Temp_DHW_top);
If (Temp_freon > Temp_DHW_top + 5) {
digitalWrite (32,1);     				//turns on subcooler pump
Serial.println(“Subcooler pump ON”);
}
If (Temp_Freon <= Temp_DHW_top + 5) {
digitalWrite (32,0); 				//turns off subcooler pump
Serial.println(“Subcooler pump OFF”);
}
}

What do you think? Will it work or have to change something? The idea is to write values from parameters 20302.1 and 8830. Compare them and if the first one is more than 5 degrees greater than second one, close the relay and start the pump...

[fredlcore]

I'm sorry, but I cannot do code-review from scratch here. Try it out for yourself first and report if something is not working. Add debug output after every value that has been set/modified to make sure that there is no error there. Then, if there is still an error, I may be able to take a look. Also, please use proper indention so that your code becomes readable.

[Ivailo1980]

I`m sorry. I thought this a kind of forum for discussions. I manage to do the code working:
This is it if somebody needs it - starts circulation pump after cheching temperature difference and state of compressor modulation of heatpump.

#define RELAY2 33

void setup();

pinMode (RELAY2, OUTPUT);

void loop();

if (custom_timer > custom_timer_compare+20000) { // every 20 seconds
custom_timer_compare = millis();
query(20302.1);
float Temp_Freon = atof(decodedTelegram.value);
Serial.print("Freon temperature in Celcius:");
Serial.println(Temp_Freon);
query(8830);
float Temp_DHW_top = atof(decodedTelegram.value);
Serial.print("DHW Top temperature in Celcius:");
Serial.println(Temp_DHW_top);
query(8413);
float Comp_modulation = atof(decodedTelegram.value);
Serial.print("Compressor modulation in %:");
Serial.println(Comp_modulation);
if (Temp_Freon>(Temp_DHW_top + 5) and (Comp_modulation>0)) {
digitalWrite(33, HIGH);
Serial.println("Subcooler Pump ON");
}
else {
digitalWrite(33, LOW);
Serial.println("Subcooler Pump OFF");
}

[fredlcore]

No, you can discuss this here of course, but to ask if the code will work without telling us if you tested it yourself isn't likely going to get a lot of feedback here. But if it works, it's a helpful approach, so thanks for sharing!