Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using collapse to speed up prais? #4

Open
SebKrantz opened this issue Nov 16, 2020 · 1 comment
Open

Using collapse to speed up prais? #4

SebKrantz opened this issue Nov 16, 2020 · 1 comment

Comments

@SebKrantz
Copy link

Hello Franz,

thank you for your great package! I would like to make this suggestion to you: My recently developed C/C++ package collapse provides a function fdiff which supports extremely fast quasi-differences on (unordered) time series and panel data. The documentation for that function is here. I'd love to see this performance implemented in Prais. collapse depends on Rcpp, so you'd have two extra dependencies (more or less one as 99% of R users have Rcpp installed).

If you don't want to create hard dependencies, you could think of adding a soft one by using if(requireNamespace("collapse", quietly = TRUE)) to check if collapse is available, and use your base R implementation otherwise.

If you go for a hard dependency, collapse also offers other functions like na_omit, qDF, qM, roworderv, funique, ss, get_vars etc. that would also help to dramatically speed up the rest of the prais code.

I don't want to intrude into your development choices of course, but It would be really cool to run prais on large panel data. Let me know what you think about this.

Best regards,

Sebastian

@franzmohr
Copy link
Owner

Thanks for the proposal. Definitely looking into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants