Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voucher markers logic #27

Open
webian opened this issue Nov 14, 2017 · 4 comments
Open

Voucher markers logic #27

webian opened this issue Nov 14, 2017 · 4 comments
Labels

Comments

@webian
Copy link
Contributor

webian commented Nov 14, 2017

I tried many ways, debugging the tx_ttproducts_voucher_view code and trying the templates that I found, but I'm failing to understand the voucher markers logic.

IMHO the FE HTML code for the voucher logic should have at least these 3 elements:
[1] voucher input field
[2] text that shows applied discount
[3] error message

When the basket is displayed the first time only [1] is displayed.

Then the user enter an invalid code: the basket refresh and it displays field [1] with the code entered and [3] with the error message. Since the user didn't yet enter a valid code, [2] is not displayed.

Then the user enter a valid code: the basket refresh and it displays field [1] with the code entered and [2] with the applied discount. It doesn't display [3] because there's no error.

Now, let's suppose that the user tries another code.

The user enter another code that is invalid: the basket refresh and it displays field [1] with the code entered and [2] with the discount of the first valid code and [3] with the error message.

The user enter another valid code: the basket refresh and it displays field [1] with the code entered and [2] with the applied discount that it's the total discount of the 2 codes. It doesn't display [3] because there's no error.

I can't achieve this with the actual code/markers of tx_ttproducts_voucher_view.

@franzholz
Copy link
Owner

Please use the forum at jambage.com to ask questions, so that other users can see them and my answers.

@webian
Copy link
Contributor Author

webian commented Nov 21, 2017

It's not a question, is more a bug report/suggestion about the voucher logic because at the moment is not enough user friendly.
But if you think that this is not the place to discuss this, please close this issue, I don't mind ;)

@franzholz
Copy link
Owner

tt_products supports the entry of one voucher code only. Always the latest voucher code is taken.
If you want to use several voucher codes at the same time, then this would be a new feature which needs some programming.

@webian webian closed this as completed Dec 15, 2017
@webian
Copy link
Contributor Author

webian commented Nov 14, 2018

@franzholz

tt_products supports the entry of one voucher code only. Always the latest voucher code is taken.

Then maybe tx_ttproducts_voucher class is bugged because if user insert more than one voucher then, the first time, the vouchers do stacks.

Example steps:

  • Basket amount: 100€
  • customer uses voucher "discount" -25%
  • applied discount: 25€ (ok)
  • customer uses voucher "anotherdiscount" -33%
  • applied discount: 58,33€ (wrong, they stacked)
  • customer visits again the basket
  • applied discount: 25€ (wrong, should be the last used 33€)

@webian webian reopened this Nov 14, 2018
@franzholz franzholz added the bug label May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants