Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency in assigned values in glod-game tutorial code #63

Open
Yttruire opened this issue May 11, 2023 · 0 comments · May be fixed by #67
Open

Inconsistency in assigned values in glod-game tutorial code #63

Yttruire opened this issue May 11, 2023 · 0 comments · May be fixed by #67
Assignees
Labels
Type: Bug Something isn't working

Comments

@Yttruire
Copy link
Contributor

Issue 1: In step 4, the value of 310.0 is assigned at first, making the character appear in the middle of the game. A "floor", or boundary is later set at the bottom of the screen so that the character does not fall off the screen. This results in the character starting at the middle of the screen on an invisible platform, jumping, then landing at the bottom of the screen which is a bit odd. In step 5.4, this value is silently changed to 620.0. This value can just be 620.0 from the start
image

Issue 2: Values 50 and 5 are used for the damage limits.
image
They are then subsequently overwritten in the later part of the code to use a margin of 120 and 15.
image

@Yttruire Yttruire added the Type: Bug Something isn't working label May 11, 2023
@Yttruire Yttruire self-assigned this May 11, 2023
@Yttruire Yttruire linked a pull request May 15, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant