Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add doc strings to snforge init template #2590

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add doc strings to snforge init template #2590

wants to merge 1 commit into from
+6 −1

Conversation

maciektr
Copy link
Contributor

I am open to any changes.

cptartur
cptartur reviewed Oct 18, 2024
View reviewed changes
Copy link
Member

@cptartur cptartur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think maybe it'd make sense to add a comment to the template saying something like "use this command to generate documentation"

@maciektr
Copy link
Contributor Author

@cptartur In the code? Seems a bit excessive, we don't really have comments instructing to run scarb build or snforge test either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cptartur cptartur cptartur left review comments

@ksew1 ksew1 Awaiting requested review from ksew1 ksew1 is a code owner

@integraledelebesgue integraledelebesgue Awaiting requested review from integraledelebesgue integraledelebesgue is a code owner

@ddoktorski ddoktorski Awaiting requested review from ddoktorski ddoktorski is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maciektr @cptartur