Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize to support Proxmox VE, Mail Gateway and Backup Server #6

Open
foundObjects opened this issue May 6, 2021 · 3 comments · May be fixed by #10
Open

Generalize to support Proxmox VE, Mail Gateway and Backup Server #6

foundObjects opened this issue May 6, 2021 · 3 comments · May be fixed by #10
Labels
enhancement New feature or request

Comments

@foundObjects
Copy link
Owner

TODO, see title.

@foundObjects foundObjects added the enhancement New feature or request label May 6, 2021
@systemcrash
Copy link

I think that for the backup server, it only need to check for the existence of proxmox-backup-proxy.service - I ran it and restarted that script. All works as it should now.

@gdeeble
Copy link

gdeeble commented Feb 4, 2023

I'm not terribly familiar with the PR process. If someone could assist with this and wants to update the pve-nag-buster.sh I added the following code to my file and it cleared the nag on PBS. The install script will need something to identify PBS and change the repo from pve to pbs as well.

Add 2 Variables:
PBS_SERVICE="$(systemctl show proxmox-backup-proxy.service --no-page | grep 'ActiveState=' | cut -f2 -d=)" PBS="$(echo "${PBS}" | grep "NoSuchUnit" | cut -f1 -d=)"

And replaced the systemctl restart pveproxy.service with the following if block:
if [ "${PBS}" != "NoSuchUnit" ] then systemctl restart proxmox-backup-proxy.service else systemctl restart pveproxy.service fi

I was able to run the nag buster script with this on both PVE and PBS. If someone has a better way to identify PVE vs PBS/PMG, I'd be quite interested in how to achieve it.

@Yukigamine
Copy link

Proxmox Backup Server actually has its own repository that is separate from PVE.

https://pbs.proxmox.com/docs/installation.html#proxmox-backup-no-subscription-repository

Same with PMG: https://forum.proxmox.com/threads/how-to-use-proxmox-mail-gateway-free-license.80130/

Just to make sure that it is getting the proper patches, that should probably be used instead.

I'm working on adapting this for my PBS server and can look into submitting a PR.

@Yukigamine Yukigamine linked a pull request Feb 15, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants