Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement version recognition #44

Open
mariobehling opened this issue Aug 22, 2024 · 5 comments · May be fixed by #53
Open

Implement version recognition #44

mariobehling opened this issue Aug 22, 2024 · 5 comments · May be fixed by #53
Assignees

Comments

@mariobehling
Copy link
Member

A mobile app should be able to recognize the version of the firmware on the hardware and provide the option to update the firmware.

@kienvo
Copy link
Member

kienvo commented Aug 22, 2024

It's already implemented in Device Information Profile:

const uint16_t firmwareRev_UUID = FIRMWARE_REV_UUID;
static const uint8_t firmwareRev_val[] = "v0.0.1";

The app should read the firmware version string by reading the value of the Firmware Revision String Characteristic (0x2A26) in the Device Information Profile (0x18A). This will be documented soon, along with the firmware versioning.

@mariobehling
Copy link
Member Author

Ok, good. When you document this please reference this issue.

@froscon2024
Copy link
Contributor

What does the preinstalled closed source firmware answer when you read out those values?
Does it even have a version?

@kienvo
Copy link
Member

kienvo commented Sep 23, 2024

What does the preinstalled closed source firmware answer when you read out those values? Does it even have a version?

They left it default as the example in the EVT package: 'Firmware Revision'. Not just that characteristic but the whole 0x180A Service was left default. I think they don't have any reason to put more effort into this.

@froscon2024
Copy link
Contributor

froscon2024 commented Sep 25, 2024

So its easy detectable with for example the android app if its closed source or the opensource firmware because none of the foss releases from fossasia would let it default like the closed source one did.
Yes, i know that the foss version looks different on the badge, but the desktop or android software that read out the firmware should also be able to know without the need of the user to choose which one is installed.

@kienvo kienvo linked a pull request Sep 29, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants