-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image Policies should specify if version tags starting with a "v" are valid #1864
Comments
It's a bit more complicated than one single answer (all the more reason to have it documented explicitly) I think the answer is no, we don't support it, because it's not in strict semver: But you may find here or there, it works, because the masterminds library is used. This is not a guarantee. Semver library says optionally support "v" - for Flux purposes, supporting For Helm, it definitely is not supported, based on a quick search of issues in the helm-controller repo. In Image Automation Controller, it seems like it is supported, based on these comments about weak semver validation: In a repo that switches from v-prefixed to non-v-prefixed versions I guess it is still easy enough to tell which one wins, v1.0.1 or 1.0.2, but if there is ambiguity in the tags, then Flux is maybe going to fail to select a latest image. If you pushed both tags When the question comes up, to avoid ambiguity in the answer, I think we always answer that it's not supported because semver.org unambiguously states that the |
On https://github.com/Masterminds/semver it looks like a tag like
v1.2.3
would be a valid SemVer tag under theSemVer
ImagePolicy. I would like to see this fact explicitly reflected (or explicitly demented, maybe with a workaround regexp if necessary) on the documentation pages for Flux.The text was updated successfully, but these errors were encountered: