Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure objects are read before making changes in tests #473

Open
hiddeco opened this issue Feb 13, 2023 · 0 comments
Open

Ensure objects are read before making changes in tests #473

hiddeco opened this issue Feb 13, 2023 · 0 comments
Labels
good first issue Good for newcomers

Comments

@hiddeco
Copy link
Member

hiddeco commented Feb 13, 2023 •
edited
Loading

Based on flakiness CI, there appear to be a couple left which do not do this, causing them to fail with patch errors once in awhile.

For example:

The other option would be to use ssa.Apply, which works around this issue.
@hiddeco hiddeco added the good first issue Good for newcomers label Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hiddeco