-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HCVault: refactor test to avoid using docker #648
Comments
This would be amazing, testing this is kinda a nightmare; having to install etcd and kube-apiserver and having to pollute our dev environment with temporary directories which may or may not be cleaned up on exit makes it kinda necessary to run them in containers, which IntelliJ thankfully supports, but having to somehow wire some container engine into the container just because some tests need this vault makes it kinda impossible again. I've resorted to just commenting out
|
The test cases in internal/sops/hcvault/keysource_test.go use
"github.com/ory/dockertest"
to spin up a test vault server.We want to replace this to avoid having a dependency with docker. Instead we want to use a HVCault test server like https://pkg.go.dev/github.com/hashicorp/vault/vault#TestCluster.
The text was updated successfully, but these errors were encountered: