-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Progressive Canary with Istio uses default URL to Prometheus #1671
Comments
Digging into the source, I can see that I might be able to specify this here https://github.com/fluxcd/flagger/blob/main/cmd/flagger/main.go#L96 ...via setting the argument on the Deployment, but it seems that I cannot pass a secrets ref https://github.com/fluxcd/flagger/blob/main/pkg/metrics/observers/factory.go#L34 Meaning I cannot reach out to an external provider. |
This was referenced Jun 28, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
When defining a Canary with Istio, Flagger appears to attempt to use a default Prometheus address.
The custom MetricTemplates can have an endpoint defined, but the default Istio metrics lookups seem to only attempt the default Prometheus address, leading to these errors:
Is it possible to set a custom endpoint with the builtin Istio metrics, or will I have to define all of these myself? It doesn't seem that I can add the
provider
block to Canary spec.To Reproduce
Deploy an Istio backed Canary with an external Prometheus endpoint.
Expected behavior
An endpoint on the CRD to define a custom Prometheus endpoint for Istio.
Additional context
The text was updated successfully, but these errors were encountered: