Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubernetes Filter doesn't enrich logs with node labels data #9538

Open
hawk-sergey-kurilo opened this issue Oct 29, 2024 · 4 comments
Open

Comments

@hawk-sergey-kurilo
Copy link

Is your feature request related to a problem? Please describe.

Kubernetes Filter doesn't enrich logs with k8s nodes labels data

Describe the solution you'd like

Would be nice to have node labels data in logs, not only hostname and pods metadata

Describe alternatives you've considered

AWS Metadata usage is not possible, it requires EC2 instance-metadata-tags option enabled, but it cannot be enabled because of tags format

Additional context

@patrick-stephens
Copy link
Contributor

We added namespace support so nodes is probably useful too.

@uristernik
Copy link
Contributor

uristernik commented Oct 30, 2024

As a workaround you can wrap the entrypoint with a script that gets these and exports them as environment variable.
It would be way better to have it natively

@patrick-stephens
Copy link
Contributor

As a workaround you can wrap the entrypoint with a script that gets these and exports them as environment variable. It would be way better to have it natively

A script? There's no shell in the distroless production images.
An alternative would be a LUA filter that does it too.

@uristernik
Copy link
Contributor

As a workaround you can wrap the entrypoint with a script that gets these and exports them as environment variable. It would be way better to have it natively

A script? There's no shell in the distroless production images. An alternative would be a LUA filter that does it too.

it's a hack more than anything... and yes, it requires shell with init container

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants