Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclusions are not honored, when the excluded bizlogic is added as a control dependency #16

Open
vibhorgarg opened this issue Sep 23, 2024 · 2 comments
Open

Exclusions are not honored, when the excluded bizlogic is added as a control dependency #16

vibhorgarg opened this issue Sep 23, 2024 · 2 comments

Comments

@vibhorgarg
Copy link

vibhorgarg commented Sep 23, 2024 •
edited
Loading

Two issues

  1. When an excluded bizlogic is added as a control dependency, it is not removed from reverseBizlogicDependencyMap, and this leads to exception in the flow as CyclicDependency.
  2. The exception itself is not correct, as removing a node is not actually leading to CyclicDependency, and this misleads the developer.

Simulated the issue here -> #15

@bageshwar / @bageshwar-pn

  1. I have also updated the FlowBuilder to be JDK 17 compliant. This enables us to build tef on jdk 8 as well as jdk 17. please review that change.
@vibhorgarg
Copy link
Author

@bageshwar , have pushed another commit with the fix for this bug as well.
Please review.

@vibhorgarg
Copy link
Author

Hi, this is the big fix -> https://github.com/flipkart-incubator/tef/pull/17/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vibhorgarg