Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improvement-suggestion] choose resolution manually #33

Open
kiai72 opened this issue May 11, 2021 · 6 comments
Open

[improvement-suggestion] choose resolution manually #33

kiai72 opened this issue May 11, 2021 · 6 comments

Comments

@kiai72
Copy link

kiai72 commented May 11, 2021

When sendtokodi starts it calls youtube-dl to download the video with "-f best" (best format), right ?
Since youtube-dl does not work reliable here (for example on welt.de it always loads the worst quality - and there are more examples like this):
It would be nice, if we could choose the format manually!

It could look like these:

  • sendtokodi starts - gets the available formats (youtube-dl --list-formats)
  • the user gets a dialog on kodi to choose the format he wants
  • a nice option would be, if we could save the choosen format by URL
    (for example on welt.de the best quality is always the first format!)

What do you think? Will you add these feature ?

@firsttris
Copy link
Owner

i think those are very good suggestions, we can consider implementing them.

due to my private situation i currently do not have time to imlement it.

but, pull requests are always welcome

p.s. source-code is very small.

best regards
Tristan

@kiai72
Copy link
Author

kiai72 commented May 13, 2021

Thank you for the offer. but i'm not able to do this. I don't even know python.

@Miteirao
Copy link

Miteirao commented Aug 9, 2021

Yes, please, add resolution selection.

@anohren
Copy link
Collaborator

anohren commented Nov 18, 2021

I added some support for resolution selection in the iOS client last year or so, with necessary support added in the plug-in. You should be able to hook into that. Only a max resolution cap though.

Personally I used iOS shortcuts to send URLs to different devices, with custom max resolution. And the iOS app for older iOS devices.

Problem is, the plug-in expects improperly formatted URLs, and as a result Kodi seems to interfere with / characters. Until it does it's not likely possible to support arbitrary format arguments with the remote clients.

@kiai72
Copy link
Author

kiai72 commented Nov 19, 2021 via email

@anohren
Copy link
Collaborator

anohren commented Nov 19, 2021

Well, I'm assuming you're sending network requests somehow. Reach out to the app author?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants