Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect value for "move complete command" in AccelStepper? #112

Open
pavhofman opened this issue Nov 25, 2019 · 3 comments
Open

Incorrect value for "move complete command" in AccelStepper? #112

pavhofman opened this issue Nov 25, 2019 · 3 comments

Comments

@pavhofman
Copy link

The "move complete command" in AccelStepper lists value 0x0b in
protocol/accelStepperFirmata.md . However, the implementations use 0x0a:

https://github.com/firmata/firmata.js/blob/488964da379b137da5ab3e7887161cbf31c60793/packages/firmata-io/lib/firmata.js#L400

https://github.com/firmata/ConfigurableFirmata/blob/master/src/AccelStepperFirmata.h#L39

Since the arduino firmware uses 0x0a, please can you fix the documentation?

Thanks a lot.

@dtex
Copy link
Contributor

dtex commented Nov 25, 2019

You are absolutely correct. I must have removed a command at some point during the implementation and forgot to update that value. I'll get a PR in ASAP.

@pavhofman
Copy link
Author

Thanks a lot for instant response :-)

@dtex
Copy link
Contributor

dtex commented Nov 25, 2019

Thank you for the catch!

It's all updated now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants