Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Architecture as Code for TraderX #127

Open
maoo opened this issue Feb 27, 2024 · 2 comments
Open

Architecture as Code for TraderX #127

maoo opened this issue Feb 27, 2024 · 2 comments
Assignees

Comments

@maoo
Copy link
Member

maoo commented Feb 27, 2024

The (FINOS) Architecture as Code Working group have built a C4 model for TraderX , and it would be great to host some docs on this repository, possibly embedding some diagrams.

I'll defer to @rocketstack-matt to decompose this, or link it to other existing issues.

@rocketstack-matt
Copy link
Member

Linking the TraderX sample built using CALM https://github.com/finos-labs/architecture-as-code/tree/main/calm/samples/traderx

Please note that the current sample is built from the C4 model, which is in fact out of date with current TraderX as of the date of this comment. This highlights a key issue with C4 (and CALM in it's current form) namely that it is separate from the actual application and can therefore get out of sync.

Tag: @dc-ms / @jpgough-ms / @yt-ms / @matthewgardner - this is a good example of a problem we want CALM to solve, namely that the changes in architecture should be driven from the manifest changing (or be identified and potentially blocked via drift detection).

@maoo
Copy link
Member Author

maoo commented Feb 28, 2024

Thanks @rocketstack-matt , your links are very helpful.

As a simple step forward, I'd suggest to add https://github.com/finos/traderX/blob/main/docs/c4/c4-diagram.png into the TraderX README, as it would help readers understanding the FW's architecture, and navigate to the Architecture as Code initiative. WDYT?

The issue related with changes is quite interesting too, and I suppose it should live into https://github.com/finos-labs/architecture-as-code/issues ; until then, I think it would be a good idea to version the C4 architecture definitions and always specify the creation date; this way we can measure the amount of changes via git history. WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants