generated from finos-labs/project-blueprint
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate does not output placeholders for boolean properties #353
Comments
willosborne
added
bug
Something isn't working
good first issue
Good for newcomers
labels
Aug 30, 2024
willosborne
added a commit
to willosborne/architecture-as-code
that referenced
this issue
Oct 18, 2024
willosborne
added a commit
to willosborne/architecture-as-code
that referenced
this issue
Oct 18, 2024
willosborne
added a commit
to willosborne/architecture-as-code
that referenced
this issue
Oct 18, 2024
rocketstack-matt
added a commit
that referenced
this issue
Oct 18, 2024
…les (#500) * #353 properly instantiate boolean properties * #353 add spectral rule to report boolean placeholder values * #353 add pattern rule to warn against using booleans --------- Co-authored-by: Matthew Bain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug Report
Steps to Reproduce:
Add a boolean field to a node, relationship or metadata object
e.g.
Expected Result:
Actual Result:
Environment:
Latest version of CLI
Additional Context:
Placeholder values are tricky here. We can't just output
false
as this could be dangerous.We should consider a warning to use enums instead of booleans.
Suggested fix for booleans is:
The text was updated successfully, but these errors were encountered: