Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unreachable code #6030

Open
3 tasks
cnlucas opened this issue Oct 28, 2024 · 0 comments
Open
3 tasks

Remove unreachable code #6030

cnlucas opened this issue Oct 28, 2024 · 0 comments

Comments

@cnlucas
Copy link
Member

cnlucas commented Oct 28, 2024

What we’re after

When @tmpayton built our new legal tests, she found a few sections of dead code that should be removed.

in legal.py we should remove lines 492-495:

if kwargs.get("case_dispositions"):
        must_clauses.append(
            Q("term", disposition__data__disposition=kwargs.get("case_dispositions"))
        )

and lines 118-121

# if doc_types is not in one of ALL_DOCUMENT_TYPES
            # then reset type = all (= ALL_DOCUMENT_TYPES)
            if doc_types[0] not in ALL_DOCUMENT_TYPES:
                doc_types = ALL_DOCUMENT_TYPES

Action item(s)

(These are the smaller tasks that should happen in order to complete this work)

  • Confirm above sections of code are dead/ Investigate any other extraneous code in legal.py
  • Remove unreachable code

Completion criteria

(What does the end state look like - as long as this task(s) is done, this work is complete)

  • All unreachable code is removed
@cnlucas cnlucas added this to the 26.6 milestone Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🔜 Sprint backlog
Development

No branches or pull requests

2 participants