Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve version problem with marshmallow-pagination #3929

Closed
jason-upchurch opened this issue Aug 26, 2019 · 2 comments
Closed

resolve version problem with marshmallow-pagination #3929

jason-upchurch opened this issue Aug 26, 2019 · 2 comments

Comments

@jason-upchurch
Copy link
Contributor

Summary

We use git+https://github.com/jmcarp/marshmallow-pagination@master in requirements.txt. This library does not appear to be maintained, e.g., jmcarp/marshmallow-pagination#3, and currently the versioning requires [email protected] while we use [email protected].

Problem

The above limits use of automated tools such as pip-compile to produce requirements.txt which includes transitive dependencies. In addition, running pipeptree produces:

* marshmallow-pagination==0.1.1
 - marshmallow-sqlalchemy [required: ==0.4.1, installed: 0.15.0]

some options to avoid the errors and increase our ability to use automated tools are:

  1. fork marshmallow-pagination and maintain
  2. rewrite or find alternative libraries to replace the functionality afforded by marshmallow-pagination
@jason-upchurch
Copy link
Contributor Author

As a test, I've added https://github.com/jason-upchurch/marshmallow-pagination and bumped version of marshmallow-paginationto reflect addition of [email protected]. Submitted PR to @jmcarp but we may need to maintain this ourselves so that we can use tools such as pipdeptree without seeing warning and pip-tools for transitive dependency management.

@jason-upchurch
Copy link
Contributor Author

closing in favor of #3952

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant