Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reports and Filings filter panel - Loading gif persists when visiting urls with querystring parameters (checkFromQuery function) #6481

Open
johnnyporkchops opened this issue Sep 22, 2024 · 0 comments · May be fixed by #6488
Assignees
Milestone

Comments

@johnnyporkchops
Copy link
Contributor

johnnyporkchops commented Sep 22, 2024

Summary

  • When visiting a URL with querystring parameters for Filing or Reports into a browser, the loading gif (three dots) keeps animating - It seems the line in checkFromQuery() in tables.js that removes this on other tables does not work for Flings and Reports and does not remove theis-loading class.

What happened?
The loading gif persists and keeps animating

What should have happened?

  • The loading gif should go away
  • The :after class should go from is_loading to is_successful and then no class

Frequency

always on Filings and Reports datatables

How to Reproduce

Go to this url and then open the Filing information section of the filter panel
https://www.fec.gov/data/filings/?data_type=processed&form_type=F1M&form_type=F3P

Screenshots

is-loading

Misc

If you'd like to include anything else that may be of interest, do that here.

@cnlucas cnlucas added this to the 26.3 milestone Sep 24, 2024
@johnnyporkchops johnnyporkchops changed the title Reports and Filings filter panel - Loading gif persists on copy-pasted urls with querystring (checkFromQuery function) Reports and Filings filter panel - Loading gif persists when visiting urls with querystring parameters (checkFromQuery function) Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 👀 Ready
Development

Successfully merging a pull request may close this issue.

2 participants