Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let's nix #104

Open
ghostbuster91 opened this issue Jan 8, 2022 · 6 comments
Open

Let's nix #104

ghostbuster91 opened this issue Jan 8, 2022 · 6 comments
Labels
enhancement New feature or request

Comments

@ghostbuster91
Copy link

ghostbuster91 commented Jan 8, 2022

Hi,

I've just found your plugin and it is awesome :) I recently started configuring my tmux as finally I have option to build my environment in a reproducible way and experiment safely thanks to lord and savior nix.

This plugin is not available (yet) in the official nix package repository (I might add it there as soon as I figure how :D ) but that is not a problem, rather a small inconvenience as it can be build from sources.

I tried doing it on my own, but after couple failed attempts I decided to look for the help on the internet.
I found that someone already did that: https://git.alarsyo.net/alarsyo/nixos-config/src/branch/tmux-thumbs/packages/tmux-thumbs.nix

Unfortunately, that doesn't work for me for some reason. I examined his patch and it looks fine to me. Maybe that's because I am using the latest version of tmux - 3.2a? 🤔

Anyway, as you can see in the linked repository, the author needed to apply some patch to both rust and sh files. It would be the best to avoid such hacks if possible.

To the point - do you think that it would be possible to make such changes so the nix-patch wouldn't be needed?

@ghostbuster91
Copy link
Author

Recording of my screen with blinking thumbs pane in the status bar:
Peek 2022-01-08 13-03

@fcsonline fcsonline added the enhancement New feature or request label Feb 2, 2022
@fcsonline
Copy link
Owner

fcsonline commented Feb 5, 2022

The installation process has changed in the last days. Can you check again?

@ghostbuster91
Copy link
Author

Hi,

It turned out that the problem was in the linked patch. I managed to fix it and make it running for the latest version - 0.7.1 :)

Here is how I did it: ghostbuster91/dot-files@d263bf7

@fcsonline
Copy link
Owner

Awesome!! Should we close the issue?

@ghostbuster91
Copy link
Author

Let's do that :)

@ghostbuster91
Copy link
Author

ghostbuster91 commented Feb 27, 2022

fyi I submitted PR to nixpkgs repository to add thumbs and tmux-thumbs: NixOS/nixpkgs#162121

I submitted myself as a maintainter of that nixpkg if you don't mind.

Please let me know if you want to make any changes or have anything against it.

=============================

Also sorry for my indecision, but I think that it would be great if we could get rid of those hacky patches. I would like to keep this issue open to discuss possible ways of making them redundant.

Let me know if you are open to fix that at all, otherwise feel free to close that issue.

@ghostbuster91 ghostbuster91 reopened this Feb 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants