Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REQUEST] Make reports#create more standard #14

Open
2 tasks done
etagwerker opened this issue Oct 12, 2023 · 0 comments · May be fixed by #15
Open
2 tasks done

[REQUEST] Make reports#create more standard #14

etagwerker opened this issue Oct 12, 2023 · 0 comments · May be fixed by #15
Assignees
@arielj
Labels
enhancement New feature or request

Comments

@etagwerker
Copy link
Member

Before we start...:

  • I checked the documentation and didn't find this feature
  • I checked to make sure that this feature has not already been requested

Branch/Commit:

main branch

Problem:

reports#create is quite low level and it might be unnecessarily complicated.

make it be more like a typical rails controller action.

I will abide by the [code of conduct] (https://github.com/fastruby/benchmark.fyi/blob/main/CODE_OF_CONDUCT.md)
@etagwerker etagwerker added the enhancement New feature or request label Oct 12, 2023
@arielj arielj self-assigned this Oct 18, 2023
@arielj arielj linked a pull request Oct 18, 2023 that will close this issue
Refactor model and controller to follow Rails conventions #15
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arielj arielj

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor model and controller to follow Rails conventions fastruby/benchmark.fyi
2 participants
@etagwerker @arielj