Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] when using scaleIn and scaleOut together, scaleOut is affected by the scaleIn value #276

Closed
Codas opened this issue Jul 23, 2024 · 1 comment

Comments

@Codas
Copy link
Contributor

Codas commented Jul 23, 2024

Describe the bug
Essentially, when using this sequence:

new Sequencer().effect().file('effect.webm').scaleIn(0.5).scaleOut(2).play()

the scaleOut animation part will seemingly not happen.

The reason for this is that the _determineScale function on canvas-effect.js takes into account the initial set scaleIn factor before calculating the scaleOut animation.

I would expect the abaove sequence insted to animate in from a scale of 0.5 to 1, then display the majority of the animation at scale 1 and finally scale out to a scale of 2 compared to the regular size after the scaleIn has completed.

@Haxxer
Copy link
Collaborator

Haxxer commented Oct 24, 2024

Fixed in 3.4.0

@Haxxer Haxxer closed this as completed Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants