-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Fortify strings check to CI #1882
Labels
kind/feature
New feature or request
Milestone
Comments
/milestone 0.18.0 This is great, thanks for opening Luca! Big enormous huge +1 from me. |
Not blocking for 0.18.0, but it'd be nice to have it. I briefly took a look at it at some point and it looks like we need to implement it ourselves sadly /milestone 0.19.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
#1880 should have been caught in CI. It happened to be detected because @FedeDP ran the test suite on a machine that had fortify turned on and
strlcpy()
was a checked version instead of the regular one that is embedded in the libs repo. We need to look into how to enable the same checks in CI as well (in the ASan build, so we can get a stack trace)The text was updated successfully, but these errors were encountered: