Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fortify strings check to CI #1882

Open
LucaGuerra opened this issue May 29, 2024 · 2 comments
Open

Add Fortify strings check to CI #1882

LucaGuerra opened this issue May 29, 2024 · 2 comments
Labels
kind/feature New feature or request
Milestone

Comments

@LucaGuerra
Copy link
Contributor

#1880 should have been caught in CI. It happened to be detected because @FedeDP ran the test suite on a machine that had fortify turned on and strlcpy() was a checked version instead of the regular one that is embedded in the libs repo. We need to look into how to enable the same checks in CI as well (in the ASan build, so we can get a stack trace)

@LucaGuerra LucaGuerra added the kind/feature New feature or request label May 29, 2024
@FedeDP
Copy link
Contributor

FedeDP commented May 29, 2024

/milestone 0.18.0

This is great, thanks for opening Luca! Big enormous huge +1 from me.

@poiana poiana added this to the 0.18.0 milestone May 29, 2024
@LucaGuerra
Copy link
Contributor Author

Not blocking for 0.18.0, but it'd be nice to have it. I briefly took a look at it at some point and it looks like we need to implement it ourselves sadly

/milestone 0.19.0

@poiana poiana modified the milestones: 0.18.0, 0.19.0 Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants