-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for fingerprint login? #227
Comments
ly works with fprint, but you have to enter a wrong password first. |
try this so your fingerprint works first then it will ask for password #%PAM-1.0 |
I don't have the required hardware to test this, but it is an issue and should be fixed |
Currently using
as my /etc/pam.d/ly, works pretty good but I need to hit enter before it accepts the fingerprint-- any idea how to remove that? |
Update: cloned the repo, added // !! BAD IDEA !! This is just for fprint stuff lol
// I think this draws the UI
if (auth_fails < 10) {
(*input_handles[active_input])(input_structs[active_input], NULL);
tb_clear();
animate(&buf);
draw_box(&buf);
draw_labels(&buf);
if (!config.hide_f1_commands)
draw_f_commands();
draw_lock_state(&buf);
position_input(&buf, &desktop, &login, &password);
draw_desktop(&desktop);
draw_input(&login);
draw_input_mask(&password);
update = config.animate;
} else {
usleep(10000);
update = cascade(&buf, &auth_fails);
}
tb_present();
// This is what happens when you press enter, which seemed to allow fprint to work
save(&desktop, &login);
auth(&desktop, &login, &password, &buf);
update = true; to line 169, which worked-- but for some reason the box is offset to the top left until a key is pressed. Oh well, good enough looking :P |
Hi guys, any updates on it? This is my
Also, if this information is of any use, I used this tutorial to enable fprintd. Edit: the same happens with i3lock for me, so it might not be an issue specific to ly, but I'm not sure. |
Hi, for anyone still with this problem, I have this: auth sufficient pam_unix.so try_first_pass likeauth nullok You have to hit enter to skip to the fingerprint authentication, and it should work the other way if you switch the first two statements. |
I have a goodix 550a fingerprint reader, and with the same pam file as mentioned by @maipley, the fingerprint is detected, but ly returns authentication faliure after scanning. I have installed the libfprint-2-tod1-goodix package from the AUR, but not sure where the issue lies. The enrollment and verification works perfectly, but ly doesn't like it. I also get a kind of faillock occurrence with all users after attempting the fingerprint, and have to resort to a different tty to login with any user. Just thought I'd put this out there. Thanks. |
+1. It'd probably have to have a PAM session running in a thread. An auth success from that thread could then be an event caught in the main loop (or just an "if_pam_success" variable). I might try this and make a PR. |
I updated my fork to include fingerprint login (via libfprintd) by default. I also made a new colorful matrix animation. It uses an old pre-Zig commit as I made the animation before the rewrite. It's a little janky but seems to work fine. https://github.com/kercre123/ly |
Thanks! When I go back to ly (killing sway) it works! Not sure why it doesn't work from boot, (I am met with a blinking cursor of death). Likely just my setup. Update: it's similar to what has been mentioned before, you need an invalid input and then the sensor will work. :) |
I can try to port the changes to zig, but its gonna take a while since I don't have much time ATM |
Looks like it might be easier to add this to the current commit since |
I pushed my commits here: https://github.com/JAicewizard/ly/tree/fingerprint, and added you as co-author. Are you ok with me creating a PR for this? If you want to have your own go thats fine too, I mainly wanted to try zig again. |
@JAicewizard Hey there! It'd be nice if you could create a PR for this. I'm not sure how @kercre123 feels about this though. |
I opened up a PR, but I noticed one issue. After logging in with fingerprint, and then logging back out again, sway doesn't start. I will not have time to debug this anytime soon, so any help would be appreciated! @kercre123 Do you have more experience with login managers? |
Nevermind! I think I fixed it, along with a major rewrite of the PR, sorry for the spam. |
I followed this guide to add fingerprint setup to
/etc/pam.d/ly
but unfortunately it didn't work.It would be nice to add support for fingerprint login and
fprint
has been a great tool to do that.The text was updated successfully, but these errors were encountered: