From c9cf14dd286a250825c2bade1237e51647d51cc2 Mon Sep 17 00:00:00 2001
From: moto <855818+mthrok@users.noreply.github.com>
Date: Fri, 4 Oct 2024 10:52:53 -0400
Subject: [PATCH] Add warning about pin_memory option

---
 src/libspdl/core/conversion.h    | 2 ++
 src/libspdl/core/storage/cpu.cpp | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/src/libspdl/core/conversion.h b/src/libspdl/core/conversion.h
index a93a9d3b..0439ebf3 100644
--- a/src/libspdl/core/conversion.h
+++ b/src/libspdl/core/conversion.h
@@ -15,6 +15,8 @@
 
 namespace spdl::core {
 
+// The actual implementation is found in
+// detail/ffmpeg/conversion.cpp
 template <MediaType media_type>
 CPUBufferPtr convert_frames(
     const std::vector<const FFmpegFrames<media_type>*>& batch,
diff --git a/src/libspdl/core/storage/cpu.cpp b/src/libspdl/core/storage/cpu.cpp
index 6481700e..3dd4eee7 100644
--- a/src/libspdl/core/storage/cpu.cpp
+++ b/src/libspdl/core/storage/cpu.cpp
@@ -33,6 +33,8 @@ CPUStorage::CPUStorage(size_t size, bool pin_memory) {
     LOG(WARNING)
         << "`pin_memory` requires SPDL with CUDA support. Falling back to CPU memory.";
 #else
+    LOG(WARNING)
+        << "`pin_memory` is under development and is currently known to be slower and unstable";
     CHECK_CUDA(
         cudaHostAlloc(&data_, size, cudaHostAllocDefault),
         "Failed to allocate pinned memory.");