Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mix of REM and PX #82

Open
tonylomax opened this issue Mar 30, 2023 · 0 comments
Open

Mix of REM and PX #82

tonylomax opened this issue Mar 30, 2023 · 0 comments

Comments

@tonylomax
Copy link
Collaborator

You have a mix of rem and px throughout your project. If possible pick and stick with one (I'd suggest rem) so that you don't have strange and unexpected styling issues and everything is nicely relative to your root font size. If you like you can set that root size to 10px (rather than the default 16px) which makes the maths nice and easy e.g. 24px === 2.4rem.

https://developer.mozilla.org/en-US/docs/Learn/CSS/Building_blocks/Values_and_units

.bubble {
position: relative;
font-family: sans-serif;
font-size: 18px;
line-height: 24px;
max-width: 300px;
background: var(--bubble-bg);
border-radius: 40px;
padding: 24px;
text-align: center;
color: #000;
/* border: 1px solid rgb(174, 174, 174); */
margin-left: 5rem;
z-index: 1;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant