-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IE11 returns a blank page #59
Comments
Thanks! I actually had the same problem in one of my projects and was investigating this. You saved a lot of time :) I'll try to release a fix as soon as possible 👍 |
After a lot of debugging it seems the problem comes from <script src="https://cdnjs.cloudflare.com/ajax/libs/core-js/2.5.3/core.min.js"></script>
<!-- This is only necessary if your app uses `fetch` -->
<script src="https://cdnjs.cloudflare.com/ajax/libs/fetch/2.0.3/fetch.min.js"></script> Could you please check and confirm if the solution works for you? |
I think some people reported that by using
I am not sure about that, and don't have access to an IE11 browser to test it. |
I can confirm that by using your polyfill suggestion everything works! |
I wonder why |
Maybe it's not |
Should I close the issue? |
can we please fix the templates then? care to send a PR? |
The problem we have right now with the templates is there's a lot of fragmentation, we can "fix" this in the simple template but then there's the elmish template, the fulma template, SAFE template, etc. We need to find an easy way to propagate these changes through several places, which has been discussed in several places but I'm not sure yet which is the best solution. Probably putting scripts and related files in an npm package and make templates download it (there's an attempt for that in the We also need to decide if we want to recommend adding the polyfill with a script tag (as seen above) or importing them in code as in the SAFE bookstore. |
The polyfills of polyfill.io are hosted on GitHub, if we know which part causes this maybe we can fix it in polyfill.io? https://github.com/Financial-Times/polyfill-service/blob/master/polyfills/Array/from/polyfill.js |
Unfortunately I don't know what's the problem exactly but maybe we can report an issue so they're aware of it. |
It seems it's already been reported: https://github.com/Financial-Times/polyfill-service/issues/1434 |
When the children of a react element are coming from another function IE11 renders a blank page.
This is a minimal example which returns a blank page on IE11.
The error log is empty, so it is very obscure what's happening here.
All other browsers I've tested (Chrome, Firefox, Edge) return the children as expected.
I've created a repo with the code: https://github.com/toburger/fable-react-ie11-minimal-repo
The text was updated successfully, but these errors were encountered: