Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JS/TS] OrdinalIgnoreCase overload for .EndsWith #3892

Merged
merged 3 commits into from
Sep 19, 2024

Conversation

goswinr
Copy link
Contributor

@goswinr goswinr commented Sep 18, 2024

@goswinr
Copy link
Contributor Author

goswinr commented Sep 18, 2024

I am not sure where to fix these failing tests, in the .fs file or in .ts ?
image

@ncave
Copy link
Collaborator

ncave commented Sep 18, 2024

@goswinr Perhaps make the third argument optional, with a sensible default.

@goswinr
Copy link
Contributor Author

goswinr commented Sep 19, 2024

@ncave Do you know why the Rust build fails? For the PR, I tried to do it properly. So went for the transformers.

@MangelMaxime
Copy link
Member

MangelMaxime commented Sep 19, 2024

@goswinr Sometimes the CI fails and re-running it works.

In the past it was due to the some unreliable behaviour in the tests but since a few days I see errors about not being able to download a NuGet package. And for the later, we can't do something about it (I believe) because we don't do anything crazy with package resolution in this repository 🤷‍♂️

So in general, if you run the tests in your machine (there is a DevContainer ready to be used if you use VSCode) then it is good enough because when we re-run the failing CI they should work at some point.

Edit: The DevContainer make it possible to run the tests on your machine without having to install Dart, Rust, Python, Node, etc on your machine. Plus if you use a Mac, there is a bug in the F#/.NET compiler we don't know how to fix (yet?). This is a StackOverflow errors which happens only when compiling Fable with Fable so sending a reproduction is difficult 😥

@goswinr
Copy link
Contributor Author

goswinr commented Sep 19, 2024

ah, great, now its green 😅

@MangelMaxime
Copy link
Member

Seems like .NET 8.0.401 introduced a bug in NuGet package resolution: NuGet/Home#13729

It seems like downgrading to 8.0.304 will fix this issue, so perhaps we are going to consider doing it at the CI level.

@MangelMaxime MangelMaxime merged commit cc914e5 into fable-compiler:main Sep 19, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants