Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate Haskell colors template - Colors.hs and colors.hs #72

Open
clach04 opened this issue Oct 13, 2024 · 1 comment
Open

Duplicate Haskell colors template - Colors.hs and colors.hs #72

clach04 opened this issue Oct 13, 2024 · 1 comment

Comments

@clach04
Copy link
Contributor

clach04 commented Oct 13, 2024

See

On the one hand this looks like a minor annoyance as it duplicates content.

For Windows users (maybe Mac? Unclear about this) this is even more annoying due to the use of a file system that will retain case BUT it is essentially case-less, this then leads to an inaccessible file and warnings from git:

C:\code\terminal>git clone https://github.com/eylles/pywal16.git
Cloning into 'pywal16'...
remote: Enumerating objects: 5580, done.
remote: Counting objects: 100% (421/421), done.
remote: Compressing objects: 100% (198/198), done.
Receiving objects: 100% (5580/5580), 872.64 KiB | 1.47 MiB/s, done. 5159 (from 1)Receiving objects: 100% (5580/5580), 724.01 KiB | 1.38 MiB/s
Resolving deltas:   1% (35/3482)
Resolving deltas: 100% (3482/3482), done.
warning: the following paths have collided (e.g. case-sensitive paths
on a case-insensitive filesystem) and only one from the same
colliding group is in the working tree:

  'pywal/templates/Colors.hs'
  'pywal/templates/colors.hs'

Checking code:

(py3venv) C:\code\terminal\pywal16>rg Colors.hs
pywal\export.py
108:        "haskell": "Colors.hs",

CHANGELOG.md
59:- Fixed `xmonad` support template Colors.hs added.

(py3venv) C:\code\terminal\pywal16>rg colors.hs
pywal\export.py
109:        "xmonad": "colors.hs",

CHANGELOG.md
109:- Added `colors.hs` template for xmonad.

I think we can remove one, and update the code to use the same filename.

My recommendation is to remove the Uppercase one, Colors.hs added 2022 in change b473c5a by @threadreaper

Retaining the 2018 change fd6820d

@threadreaper and @eylles thoughts? I'm happy to open a PR if this sounds reasonable. I'm not using these so whilst I'm confident this is a reasonable plan, it won't impact me negatively if it's a terrible idea 😆

@eylles
Copy link
Owner

eylles commented Oct 13, 2024

ah, well to keep one it would be the later one, as that was the fix for xmonad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants