Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dialyzer warnings from list_secret/1 and create_secret/1 #6

Open
fmterrorf opened this issue Mar 9, 2023 · 0 comments
Open

Dialyzer warnings from list_secret/1 and create_secret/1 #6

fmterrorf opened this issue Mar 9, 2023 · 0 comments

Comments

@fmterrorf
Copy link

fmterrorf commented Mar 9, 2023 •
edited
Loading

The list_secret/1 typespec https://github.com/ex-aws/ex_aws_secretsmanager/blob/master/lib/ex_aws/secretsmanager.ex#L93-L98 indicates that it only accepts the following as an argument

  @type list_secrets_opts :: [
          {:max_results, integer} | {:next_token, binary}
        ]

The ListSecret API now accepts parameters such as Filters, SortOrder and others see https://docs.aws.amazon.com/secretsmanager/latest/apireference/API_ListSecrets.html.

Maybe we should just drop the list_secret_opts typespec or update it so that Dialyzer doesn't get mad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fmterrorf