Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SMSAdvance/PocketNES/Goomba: Consider using the raw save filename to populate the game title field #135

Open
euan-forrester opened this issue Jul 3, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@euan-forrester
Copy link
Owner

Right now we populate that field with:

  • Made with savefileconverter.com: SMSAdvance
  • SAVE: PocketNES (consistent with how it appears when running in standalone mode on an EZ Flash ODE)
  • The internal name from the game ROM: Goomba

We could consider unifying this to contain the filename of the raw file it was converted from (assuming that Goomba doesn't use the internal ROM name to verify the save is for the correct ROM. It also has the checksum for that. More code reading needed here).

I don't believe that these names appear anywhere in the emulator UI, but if we did #134 then it would be nice to have something better to display in our UI.

@euan-forrester euan-forrester changed the title SMSAdvance/PocketNES/Goomba: Consider using the ROM filename to populate the game title field SMSAdvance/PocketNES/Goomba: Consider using the raw save filename to populate the game title field Jul 3, 2022
@euan-forrester euan-forrester added the enhancement New feature or request label Jul 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant