Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EnsureRenderedStringPattern preprocessor should warn without rejecting strings containing verbatim directives #4

Open
mchalek opened this issue Nov 15, 2018 · 1 comment
Labels
enhancement New feature or request

Comments

@mchalek
Copy link
Member

mchalek commented Nov 15, 2018

Right now, if you have a parameter that uses the EnsureRenderedStringPattern pre-processor, and if you pass a verbatim string to this parameter, there is a chance that the parameter value will be rejected as invalid because the characters < and > are not supported by the provided regular expression. An example is the dataproc cluster_name parameter. We should recognize this condition and generate a warning, like we do when we encounter a jinja template that we do not know how to render.

@hyungoos
Copy link
Contributor

Thanks for creating tracking this down!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants