Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unification of interfaces across secp256k1 and bls #119

Open
pipermerriam opened this issue Mar 12, 2021 · 0 comments
Open

Unification of interfaces across secp256k1 and bls #119

pipermerriam opened this issue Mar 12, 2021 · 0 comments

Comments

@pipermerriam
Copy link
Member

What is wrong?

It would be nice if py_ecc.secpk256k1, py_ecc.bls12_381 and py_ecc.bn128 all had roughly the same API.

How can it be fixed

A combination of exposing a few un-exposed APIs from secpk256k1 and renaming things.

  • expose add and multiply from py_ecc.secp256k1.secp256k1 from py_ecc.secp256k1
  • I think py_ecc.secp256k1.secp256k1.inv needs to be renamed/aliased to neg to line up with the bls/bn APIs.
  • some other things like field_modulus and curve_order might need to have their equivalent values exposed from secp256k1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pipermerriam