Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose factories for 3rd party use #69

Open
pipermerriam opened this issue Mar 26, 2020 · 1 comment
Open

Expose factories for 3rd party use #69

pipermerriam opened this issue Mar 26, 2020 · 1 comment
Labels
Good First Issue p4

Comments

@pipermerriam
Copy link
Member

What was wrong?

It is nice to be able to easily generate dummy data for tests.

https://github.com/ethereum/trinity/blob/545a1d59eb78195bef00a83f5d40cbfa267f31cf/p2p/tools/factories/keys.py

The above uses factory-boy to create factories for generating PublicKey and PrivateKey instances for testing.

How can it be fixed?

  • copy the factories from above into eth_keys.tools.factories
  • document their existence and usage in the docs.
  • add a [factories] into the extras_require that includes the factory-boy dependency.
@JC-swEng
Copy link

Is this issue still open?

pacrob pushed a commit to pacrob/eth-keys that referenced this issue Dec 20, 2023
@kclowes
Add Python 3.11, add more black checks, remove upper pins (ethereum#69)
7b0bc76
@pacrob pacrob added p3 p4 and removed p3 labels Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue p4
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pipermerriam @pacrob @JC-swEng